python312Packages.binwalk: support Python 3.12#325865
Closed
dotlambda wants to merge 2 commits intoNixOS:masterfrom
Closed
python312Packages.binwalk: support Python 3.12#325865dotlambda wants to merge 2 commits intoNixOS:masterfrom
dotlambda wants to merge 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
dotlambda
changed the title
dotlambda
force-pushed
the
python3Packages.binwalk
branch
from
78cf085 to
6794860
Compare
This was referenced Jul 9, 2024
ofborg
bot
added
8.has: package (new)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Contributor
|
Since upstream binwalk is unmaintained, I think we should consider moving to a fork instead; there's already one used by Gentoo and Alpine Linux. I made a PR for it: #326295. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
partially replaces #325623
However this PR reveals that binwalk's tests fail under Python 3.12 which makes it sound like we should pin to Python 3.11.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.