Skip to content

python312Packages.jaconv: don't use nose#325847

Merged
mweinelt merged 3 commits intoNixOS:masterfrom
dotlambda:python3Packages.jaconv
Jul 9, 2024
Merged

python312Packages.jaconv: don't use nose#325847
mweinelt merged 3 commits intoNixOS:masterfrom
dotlambda:python3Packages.jaconv

Conversation

@dotlambda
Copy link
Member

Description of changes

better version of #325680

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda requested a review from StarGate01 July 9, 2024 13:48
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 9, 2024
@ofborg ofborg bot requested a review from fabaff July 9, 2024 15:11
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 9, 2024
@mweinelt mweinelt merged commit 0d7271a into NixOS:master Jul 9, 2024
@dotlambda dotlambda deleted the python3Packages.jaconv branch July 9, 2024 15:42
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-325847-to-release-24.05 origin/release-24.05
cd .worktree/backport-325847-to-release-24.05
git switch --create backport-325847-to-release-24.05
git cherry-pick -x c97a3ace23de27a80012cb95db5a55d29ae55fb0 195215f7e048f44b79e8b7dad33cf790dc019af1 75bc8aa03a38155457c72c6d80f8fcb9c25c9b4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants