Skip to content

python312Packages.xlib: disable tests for python 3.12#325676

Merged
fpletz merged 1 commit intoNixOS:masterfrom
StarGate01:fix-xlib
Jul 9, 2024
Merged

python312Packages.xlib: disable tests for python 3.12#325676
fpletz merged 1 commit intoNixOS:masterfrom
StarGate01:fix-xlib

Conversation

@StarGate01
Copy link
Member

@StarGate01 StarGate01 commented Jul 9, 2024

Description of changes

Since the default Python version was upgraded from 3.11 to 3.12, some packges broke which depend on Python packages not compatible with 3.12.

xlib requires nose, which does not support 3.12 . The alternative pynose (https://pypi.org/project/pynose/) does support 3.12, and does the same job.

This fixes the build of neofetch (via ueberzug) .

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 9, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 9, 2024
@StarGate01 StarGate01 requested a review from fabaff July 9, 2024 01:35
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pynose violates the license and will be removed. #325669
If you need nose for testing, please disable tests in 3.12.

@StarGate01 StarGate01 force-pushed the fix-xlib branch 2 times, most recently from 799862e to 0d78821 Compare July 9, 2024 02:46
@StarGate01 StarGate01 changed the title python312Packages.xlib: replace nose with pynose python312Packages.xlib: disable tests for python 3.12 Jul 9, 2024
@StarGate01 StarGate01 requested a review from natsukium July 9, 2024 02:49
@ofborg ofborg bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 9, 2024
@StarGate01
Copy link
Member Author

Thanks for the heads-up @natsukium , I have modified the PR as you suggested. Also did the same to #325680 .

@fpletz fpletz dismissed natsukium’s stale review July 9, 2024 13:31

Tests now disabled for Python 3.12

@fpletz fpletz merged commit 9eb6c80 into NixOS:master Jul 9, 2024
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wasn't the nose dependency simply removed? #325872

@fpletz
Copy link
Member

fpletz commented Jul 9, 2024

Oh yeah, sorry. 🤦

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Successfully created backport PR for release-24.05:

@StarGate01 StarGate01 deleted the fix-xlib branch February 6, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants