Skip to content

python312Packages.pynose: drop due to licensing issues#325669

Merged
mweinelt merged 46 commits intoNixOS:masterfrom
mweinelt:drop-pynose
Jul 9, 2024
Merged

python312Packages.pynose: drop due to licensing issues#325669
mweinelt merged 46 commits intoNixOS:masterfrom
mweinelt:drop-pynose

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jul 8, 2024 •
edited
Loading

Description of changes

mdmintz/pynose#16
#311054

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt mweinelt requested a review from natsukium as a code owner July 8, 2024 23:32
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 8, 2024
@MostAwesomeDude MostAwesomeDude mentioned this pull request Jul 8, 2024
Closed
@MostAwesomeDude
Copy link
Contributor

MostAwesomeDude commented Jul 8, 2024

Thanks for this hard work! Offhand, I don't see any issues. However, there may be a bigger problem; in this Mastodon thread many folks are bringing together a lot of evidence that multiple Python packages uploaded by this maintainer are improperly licensed. I'm not sure where to take this next; perhaps it needs to come up in Discourse. While this PR should be merged when it's ready, we may need a more systemic response as well.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 9, 2024
This was referenced Jul 9, 2024
Merged
Merged
Closed
Closed
Closed
@mweinelt mweinelt marked this pull request as draft July 9, 2024 13:41
@mweinelt mweinelt changed the base branch from staging to master July 9, 2024 13:43
@mweinelt mweinelt marked this pull request as ready for review July 9, 2024 13:46
@mweinelt
Copy link
Member Author

mweinelt commented Jul 9, 2024 •
edited
Loading

1807 rebuilds per target across 47 commits is not too bad.

@vcunat
Copy link
Member

vcunat commented Jul 9, 2024

For reference, this PR took a bit different approach:
#323410

@nixos-discourse
Copy link

nixos-discourse commented Jul 9, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/error-nose-1-3-7-not-supported-for-interpreter-python3-12/48703/8

@dotlambda
Copy link
Member

dotlambda commented Jul 9, 2024

For reference, this PR took a bit different approach: #323410

So do #325847 and #325865.

@nixos-discourse
Copy link

nixos-discourse commented Jul 9, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/distrusting-upstream-packages-from-mdmintz/48745/1

dotlambda
dotlambda reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the xlib commit: #325872

@dotlambda dotlambda mentioned this pull request Jul 9, 2024
Closed
13 tasks
@nixos-discourse
Copy link

nixos-discourse commented Jul 9, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/error-nose-1-3-7-not-supported-for-interpreter-python3-12/48703/12

@mweinelt
python312Packaegs.kazoo: remove pynose
1a4a79a 
It was apparently unused.
mweinelt and others added 16 commits July 9, 2024 17:27
@mweinelt @collares
python312Packages.ipython-genutils: migrate to pytest
75f9023 
Co-Authored-By: Mauricio Collares <[email protected]>
@mweinelt
python312Packages.nwdiag: revert to nose, disable tests on 3.12
8ec1f15
@mweinelt
python312Packages.agate: replace nose with pytests
7e97b87
@mweinelt
python312Packages.flask-assets: disable tests, add imports check
0b06e77
@mweinelt
python312Packages.svgutils: revert to nose, disable tests on 3.12
61bcf52
@mweinelt
python312Pacakges.bc-python-hcl2: drop (py)nose dependency
4749b5d
@mweinelt
python312Packages.apricot-select: replace pynose with nose
c886f78
@mweinelt
python312Packages.hkdf: revert to nose, disable tests on 3.12
a9ceeba
@mweinelt
python312Packages.python-whois: drop pynose dependency
06ebece
@mweinelt
python312Packages.pycron: remove nose dependency
700e31b
@mweinelt
python312Packages.statsd: migrate to pytest
3184ac1
@mweinelt
python312Packages.opuslib: migrate to pytest
06505fc
@mweinelt
tarsnapper: revert to nose, disable tests on 3.12
95a7ecd
@mweinelt
python312Packages.pytest-mpl: drop (py)nose dependency
400cb9b
@mweinelt
hydrus: revert to nose, disable tests on 3.12
fae12c5
@mweinelt
python312Packages.pynose: drop
22e2f20 
The pynose package violates the license of nose, which is distributed
under the LGPL license, by redistributing its code under the MIT license.
@mweinelt mweinelt mentioned this pull request Jul 9, 2024
Closed
13 tasks
@mweinelt mweinelt merged commit 49a4992 into NixOS:master Jul 9, 2024
@mweinelt mweinelt deleted the drop-pynose branch July 9, 2024 15:38
@dotlambda dotlambda mentioned this pull request Jul 9, 2024
Merged
13 tasks
@dschrempf
Copy link
Contributor

dschrempf commented Jul 9, 2024

FYI: The license of pynose has been adapted to LGPL-2: mdmintz/pynose@c3aa742.

@mweinelt
Copy link
Member Author

mweinelt commented Jul 9, 2024

Yeah, maybe. But the lost trust needs to be restored, before I'll consider allowing it back in. Right now #325935 looks more interesting to me.

@mightyiam
Copy link

mightyiam commented Jul 10, 2024

Thank you, @mweinelt

@dschrempf
Copy link
Contributor

dschrempf commented Jul 10, 2024

Yes, I also want to thank you @mweinelt. This was a fast and professional cleansing.

@collares
Copy link
Member

collares commented Jul 10, 2024

One more "thank you @mweinelt" for the prompt response. The upstream response to the licensing issue is simply atrocious.

@pbsds pbsds mentioned this pull request Jul 10, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@natsukium natsukium Awaiting requested review from natsukium

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mweinelt @MostAwesomeDude @vcunat @nixos-discourse @dotlambda @dschrempf @mightyiam @collares