Skip to content

nixos-option: fix self inclusive src (move src)#325614

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
Stunkymonkey:nixos-option-test
Jul 10, 2024
Merged

nixos-option: fix self inclusive src (move src)#325614
Aleksanaa merged 1 commit intoNixOS:masterfrom
Stunkymonkey:nixos-option-test

Conversation

@Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Jul 8, 2024

Description of changes

part of #301014

tried before via: #307564, but was reverted by #307936

for testing i used: nix-build -A nixosTests.installer.lvm

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey requested a review from K900 July 8, 2024 18:58
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 8, 2024
@Aleksanaa Aleksanaa merged commit 9eec214 into NixOS:master Jul 10, 2024
@Stunkymonkey Stunkymonkey deleted the nixos-option-test branch June 2, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants