libical: fix strict deps#324951
Merged
emilazy merged 1 commit intoNixOS:stagingfrom Jul 27, 2024
paparodeo:libical-strict-deps
Merged
libical: fix strict deps#324951emilazy merged 1 commit intoNixOS:stagingfrom paparodeo:libical-strict-deps
emilazy merged 1 commit intoNixOS:stagingfrom
paparodeo:libical-strict-deps
Conversation
add icu to nativeBuildInputs
ofborg
bot
added
10.rebuild-darwin: 101-500
This was referenced Jul 24, 2024
13 tasks
SomeoneSerge
approved these changes
Jul 26, 2024
Contributor
Author
|
i don't see a reason to delay. all the strictDeps fixes to the various packages are ready to get merged independently of the cmake fix. |
emilazy
approved these changes
Jul 27, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
This is on staging so it shouldn’t cause additional rebuilds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
strict deps doesn't quite work for cmake as it pulls in buildInputs into the PATH. this change uses a fix for cmake #318226 so this doesn't happen and then fixes the packages that set strict deps but broke with the fixed cmake.
staging companion to: #324545
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.