Skip to content

spago-legacy: 0.21.0 -> 0.21.1, rename from spago#324944

Merged
sternenseemann merged 3 commits intoNixOS:staging-nextfrom
peterbecich:rename-spago
Sep 28, 2025
Merged

spago-legacy: 0.21.0 -> 0.21.1, rename from spago#324944
sternenseemann merged 3 commits intoNixOS:staging-nextfrom
peterbecich:rename-spago

Conversation

@peterbecich
Copy link
Contributor

@peterbecich peterbecich commented Jul 6, 2024 •
edited by sternenseemann
Loading

The Spago package in NixPkgs has moved from
https://github.com/purescript/spago to https://github.com/purescript/spago-legacy.

I believe the new spago https://github.com/purescript/spago is a rewrite from Haskell to PureScript. To support this new Spago in NixPkgs will probably require rewriting all of the Nix configuration. I.m.o. the easiest way to clear the path for this is to rename the old Nix configuration from spago to spago-legacy.

Because part of this is generated by cabal2nix, changes to the spago-legacy Cabal file are needed: purescript/spago-legacy#3 This has been done now.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jul 6, 2024
peterbecich
peterbecich commented Jul 6, 2024
View reviewed changes
@peterbecich peterbecich mentioned this pull request Jul 6, 2024
Closed
@peterbecich peterbecich mentioned this pull request Jul 28, 2024
Merged
3 tasks
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 28, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
@sternenseemann
Copy link
Member

sternenseemann commented Sep 12, 2025

Hi, what's the state of this? spago with fsnotify >= 4 would be great for #429810!

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 12, 2025
@sternenseemann sternenseemann changed the base branch from haskell-updates to staging-next September 23, 2025 11:32
@nixpkgs-ci nixpkgs-ci bot closed this Sep 23, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Sep 23, 2025
@sternenseemann
Copy link
Member

sternenseemann commented Sep 23, 2025

@peterbecich I went ahead and updated this to update to spago-legacy 0.21.1. Thanks for all your work on this!

@sternenseemann sternenseemann marked this pull request as ready for review September 23, 2025 11:32
@sternenseemann sternenseemann changed the title haskellPackages.spago: rename to spago-legacy spago-legacy: 0.21.0 -> 0.21.1, rename from spago Sep 23, 2025
@sternenseemann
Copy link
Member

sternenseemann commented Sep 23, 2025

passthru.tests fail with purescript/spago-legacy#4, but this is already the case on master.

@sternenseemann sternenseemann mentioned this pull request Sep 23, 2025
Merged
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 23, 2025
@sternenseemann
Copy link
Member

sternenseemann commented Sep 23, 2025

passthru.tests fail with purescript/spago-legacy#4, but this is already the case on master.

Tests are resolved by applying Gabriella439/turtle#459 on turtle. We can do that in a separate PR!

@sternenseemann

This comment was marked as outdated.

Sign in to view
@sternenseemann sternenseemann mentioned this pull request Sep 28, 2025
Merged
wolfgangwalther
wolfgangwalther requested changes Sep 28, 2025
View reviewed changes
pkgs/top-level/aliases.nix Outdated
@@ -2340,6 +2340,7 @@ mapAliases {
soundOfSorting = sound-of-sorting; # Added 2023-07-07
SP800-90B_EntropyAssessment = sp800-90b-entropyassessment; # Added on 2024-06-12
SPAdes = spades; # Added 2024-06-12
spago = spago-legacy; # Added 2025-09-23
Copy link
Contributor

@wolfgangwalther wolfgangwalther Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to stay forever, or be removed eventually?

If the latter, we should add a warning based on lib.warnOnInstantiate. If the former, we should add a reason why it needs to stay.

Copy link
Member

@sternenseemann sternenseemann Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really depends. Ideally, we'd just package “spago@next” at pkgs.spago which would upgrade it seamlessly for existing users. I do not know when/if this is going to happen. I will not invest time into this as I don't use PureScript. My impression is that purescript doesn't receive a lot of attention in Nixpkgs lately, but I may be wrong.

Upstream PureScript devs seem to have little interest in having their work packaged by Nixpkgs and provide an overlay instead.

Copy link

@f-f f-f Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chiming in as the main Spago maintainer - spago-legacy is not likely to see any maintenance, so once spago-next is stable for some amount of time and we feel like we have migrated the majority of the community then we can properly deprecate it. But yes, as @sternenseemann mentioned usually people that are looking for purescript tooling in nix will use our overlay.

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Sep 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 324944
Commit: 72fb874cbd6262e3b858e2c47ee8f3c834292adb

x86_64-linux

✅ 4 packages built:
  • haskell.package-list
  • haskellPackages.spago-legacy
  • haskellPackages.spago-legacy.doc
  • spago-legacy

aarch64-linux

✅ 4 packages built:
  • haskell.package-list
  • haskellPackages.spago-legacy
  • haskellPackages.spago-legacy.doc
  • spago-legacy

x86_64-darwin

✅ 4 packages built:
  • haskell.package-list
  • haskellPackages.spago-legacy
  • haskellPackages.spago-legacy.doc
  • spago-legacy

aarch64-darwin

✅ 4 packages built:
  • haskell.package-list
  • haskellPackages.spago-legacy
  • haskellPackages.spago-legacy.doc
  • spago-legacy

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 28, 2025
@sternenseemann sternenseemann merged commit a3bce32 into NixOS:staging-next Sep 28, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

+1 more reviewer

@f-f f-f f-f left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterbecich @sternenseemann @wolfgangwalther @f-f @wegank