darwin.xnu: use unwrapped clang for MIGCC#324440
Merged
toonn merged 1 commit intoNixOS:stagingfrom Jul 13, 2024
paparodeo:xnu-unwrapped-clang
Merged
darwin.xnu: use unwrapped clang for MIGCC#324440toonn merged 1 commit intoNixOS:stagingfrom paparodeo:xnu-unwrapped-clang
toonn merged 1 commit intoNixOS:stagingfrom
paparodeo:xnu-unwrapped-clang
Conversation
13 tasks
ofborg
bot
added
6.topic: darwin
Contributor
Author
|
xnu headers built fine on aarch64 moving to staging. |
Contributor
Author
|
cc: @reckenrode @toonn |
toonn
reviewed
Jul 7, 2024
Contributor
Author
|
#324155 (comment) merged. marking this as draft till it makes it to staging so i can rebase and fix the merge conflict i created [edit] rebased and resolved. |
the mig header build requires a 32 bit arch but the wrapped compiler specifies `-arch 64-bit-arch` on the command line causing compile failures. This was worked around for aarch64 by patching out the 32 bit arch but that ignores the comment and the code saying that 32 bit arch is required and thus will generate the wrong sizes for the structures in the headers. Using the unwrapped clang mig can pass whatever arch it desires.
toonn
approved these changes
Jul 13, 2024
Contributor
toonn
left a comment
toonn
left a comment
There was a problem hiding this comment.
stdenv built on x86_64-darwin, that's enough to get my stamp of approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
#324155 (comment)
the mig header build requires a 32 bit arch but the wrapped compiler specifies
-arch 64-bit-archon the command line causing compile failures. This was worked around for aarch64 by patching out the 32 bit arch but that ignores the comment and the code saying that 32 bit arch is required and thus will generate the wrong sizes for the structures in the headers. Using the unwrapped clang mig can pass whatever arch it desires.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.