mkl: fix self-inclusive test src#323634
Merged
infinisil merged 1 commit intoNixOS:masterfrom Jul 16, 2024
Merged
Conversation
37 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Stunkymonkey
changed the title
infinisil
approved these changes
Jul 16, 2024
Member
There was a problem hiding this comment.
Looks like the -seq tests do work:
$ nix-build -A mkl.tests.pkg-config-dynamic-seq -A mkl.tests.pkg-config-static-seq --arg config '{ allowUnfree = true; }'
/nix/store/9jpvkkgrs01sbpywrkrkx5nxmrmkhjg6-mkl-test-2023.1.0.46342
/nix/store/h4z3c20pfh956w1rvdsvq6cspih5fq69-mkl-test-2023.1.0.46342
Thanks, looking good to me!
Note that for a non-test derivation it would be better to do this:
src = lib.fileset.toSource {
root = ./.;
fileset = ./test.c;
};because this allows overriding/getting the source using .src, but that really doesn't matter here :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #301014
sadly the test no longer works.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.