python312Packages.ipython-genutils: remove nose test dependency#323410
Closed
collares wants to merge 1 commit intoNixOS:masterfrom
Closed
python312Packages.ipython-genutils: remove nose test dependency#323410collares wants to merge 1 commit intoNixOS:masterfrom
collares wants to merge 1 commit intoNixOS:masterfrom
Conversation
Member
Author
|
I only really care about Sage and Sage 10.3 already removed |
This was referenced Jul 6, 2024
Member
|
Can you please rebase? |
Member
|
Included in #325669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This package was disabled because upstream said "DO NOT USE" on PyPI, and because it depends on the unmaintained
nosetest framework. There's some nuance to the first point, however. As you can see by looking at the repository README, the full recommendation is that "no packages outside IPython/Jupyter should depend on it". Unfortunately, nbclassic is an actively maintained part of Jupyter which depends on ipython-genutils, so we have to keep it alive for now.The options to do so are either to keep
nosealive (as Arch does) or to migratenosetests topytest(as openSUSE does). I picked the latter option and imported the openSUSE patch. Three and a half years ago, openSUSE devs notified upstream at ipython/ipython_genutils#17, but upstream thought fully eliminating ipython-genutils was in the near future; it hasn't happened so far.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.