Skip to content

Comments

init devShellTools#323398

Merged
infinisil merged 3 commits intomasterfrom
prep-dev-shell
Jul 3, 2024
Merged

init devShellTools#323398
infinisil merged 3 commits intomasterfrom
prep-dev-shell

Conversation

@roberth
Copy link
Member

@roberth roberth commented Jun 29, 2024

Description of changes

The goal is to make the logic written for dockerTools.makeNixShellImage reusable outside of that context.
We can't factor it out wholesale, so I'd like to do it piece by piece, so that it's easy to piece together solutions for other, slightly different use cases as well.

These (simple) refactors will support use cases such as

More concretely, this already

  • Adds tests for the stringValue function
  • Adds documentation

This is very repeatable, so if you like the goal or enjoy this kind of thing:
help out if you can :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@roberth roberth requested a review from infinisil June 29, 2024 15:16
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Jun 29, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 29, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, this looks good to me!

@roberth roberth marked this pull request as ready for review June 30, 2024 21:01
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 30, 2024
@infinisil infinisil merged commit 06a8bee into master Jul 3, 2024
@infinisil infinisil deleted the prep-dev-shell branch July 3, 2024 03:19
@roberth
Copy link
Member Author

roberth commented Jul 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants