haskellPackages.ghc98: fix singletons packages#323273
Merged
maralorn merged 4 commits intoNixOS:haskell-updatesfrom Jul 4, 2024
Merged
haskellPackages.ghc98: fix singletons packages#323273maralorn merged 4 commits intoNixOS:haskell-updatesfrom
maralorn merged 4 commits intoNixOS:haskell-updatesfrom
Conversation
mpscholten
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
With v1.16 the package is building again on GHC9.8
mpscholten
force-pushed
the
fix-th-desugar
branch
from
370f58a to
169cac0
Compare
mpscholten
changed the title
mpscholten
commented
Jun 29, 2024
| - ShellCheck == 0.9.0 # 2024-03-21: pinned by haskell-ci | ||
| - versions < 6 # 2024-04-22: required by spago-0.21 | ||
| - fsnotify < 0.4 # 2024-04-22: required by spago-0.21 | ||
| - th-desugar == 1.16 # 2024-06-28: preserve for GHC 9.8 |
Contributor
Author
There was a problem hiding this comment.
I hope this is the correct way to force a specific version into hackage-packages.nix 👍
ofborg
bot
added
10.rebuild-darwin: 0
mpscholten
changed the title
Contributor
Author
|
@maralorn could you take a look? |
Member
|
Thank you. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
We use the
unitspackages in a project. It depend onsingletons-base. This PR fixes all the singletons packages for GHC 9.8.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.