ed: fix docs location. Fixes #32150. Supersedes #32315.#32322
Merged
orivej merged 3 commits intoNixOS:stagingfrom Dec 4, 2017
Merged
ed: fix docs location. Fixes #32150. Supersedes #32315.#32322orivej merged 3 commits intoNixOS:stagingfrom
orivej merged 3 commits intoNixOS:stagingfrom
Conversation
GrahamcOfBorg
added
10.rebuild-darwin-stdenv
by removing installFlags and configureFlags. Fixes NixOS#32159
orivej
changed the title
Contributor
|
Thanks! Fixed the issues you outlined. |
Member
|
The lack of the CC will probably break cross though. |
Contributor
Author
|
After @orivej suggested it could be omitted, I confirmed that it made no difference on my system, so we removed it. |
Contributor
|
Cross exports CC, and |
Member
|
I'd love to be wrong, but I recall the configure script was not influenced by the environment, falling back on its own definition of |
Member
Contributor
|
#32489 fixes cross |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
DESTDIRwas set manually, but otherinstallFlagswere missing. Nix could fill the gaps, but that resulted in some wrong directories: man pages ended up in/nix/store/<hash>-ed/nix/store/<hash>-ed/share/.The solution is simple: let nix figure it all out.
#32315 caused mass rebuilding. As suggested by @orivej, I rebased the commit on
staging.I now also removed the configureFlags.
Please review the entire default.nix file for further improvements. I 'd be happy to include more 'modernizations' and avoid extra mass rebuilding.
There's no maintainer set. Any volonteers?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)