ocamlPackages.reason-native: 2022-08-31-a0ddab6 -> <version>-unstable-2024-05-07#322767
Merged
vbgl merged 1 commit intoNixOS:masterfrom Jun 28, 2024
Merged
ocamlPackages.reason-native: 2022-08-31-a0ddab6 -> <version>-unstable-2024-05-07#322767vbgl merged 1 commit intoNixOS:masterfrom
vbgl merged 1 commit intoNixOS:masterfrom
Conversation
philiptaron
requested review from
Et7f3 and
superherointj
and removed request for
ulrikstrid
github-actions
bot
added
the
6.topic: ocaml
ofborg
bot
added
10.rebuild-darwin: 0
vbgl
reviewed
Jun 27, 2024
Contributor
When I initially packaged this I wasn't aware of:
Can be executed as:
Things need to be tweaked a bit. But it could prove helpful in case you want to keep it fresh, not that upstream is changing much. |
…-2024-05-07 Upstream doesn't use releases, branches, or tags, so this is the most recent commit: reasonml/reason-native@20b1997 * ocamlPackages.reason-native.cli: init at 0.0.1-alpha-unstable-2024-05-07 * ocamlPackages.reason-native.console: 2022-08-31-a0ddab6 -> 0.1.0-unstable-2024-05-07 * ocamlPackages.reason-native.dir: 2022-08-31-a0ddab6 -> 0.0.1-unstable-2024-05-07 * ocamlPackages.reason-native.file-context-printer: 2022-08-31-a0ddab6 -> 0.0.3-unstable-2024-05-07 * ocamlPackages.reason-native.fp: 2022-08-31-a0ddab6 -> 0.0.1-unstable-2024-05-07 * ocamlPackages.reason-native.frame: init at 0.0.1-unstable-2024-05-07 * ocamlPackages.reason-native.fs: init at 0.0.2-unstable-2024-05-07 * ocamlPackages.reason-native.pastel: 2022-08-31-a0ddab6 -> 0.3.0-unstable-2024-05-07 * ocamlPackages.reason-native.pastel-console: 2022-08-31-a0ddab6 -> 0.0.0-unstable-2024-05-07 * ocamlPackages.reason-native.qcheck-rely: 2022-08-31-a0ddab6 -> 1.0.2-unstable-2024-05-07 * ocamlPackages.reason-native.refmterr: 2022-08-31-a0ddab6 -> 3.3.0-unstable-2024-05-07 * ocamlPackages.reason-native.rely: 2022-08-31-a0ddab6 -> 4.0.0-unstable-2024-05-07 * ocamlPackages.reason-native.rely-junit-reporter: 2022-08-31-a0ddab6 -> 1.0.0-unstable-2024-05-07 * ocamlPackages.reason-native.unicode: init at 0.0.0-unstable-2024-05-07 * ocamlPackages.reason-native.unicode-config: init at 0.0.0-unstable-2024-05-07 * ocamlPackages.reason-native.utf8: init at 0.1.0-unstable-2024-05-07 The version numbers are taken from upstream's `<package>.json` file. I also fixed and updated `ocamlPackages.reason-native.console.tests` so that it builds and no longer includes its `default.nix` file.
philiptaron
force-pushed
the
reason-native
branch
from
afc8c6b to
9fa3b0f
Compare
Contributor
Author
Thanks for the link and the information. I thought about how updates would happen, given that this update was a little manual... but that slow rate of changes made me think it wasn't going to be an issue. If I'm in the area again in another couple years, let's see if I think differently. |
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Upstream doesn't use releases, branches, or tags, so this is the most recent commit: reasonml/reason-native@20b1997
The version numbers are taken from upstream's
<package>.jsonfile.The constituent packages were in an almost-but-not-quite
callPackagestyle. I've updated them so that they're all actual packages. There's a mild amount of duplication induced by doing so, but no more so than every package inpkgs/by-name.I also fixed and updated
ocamlPackages.reason-native.console.testsso that it builds and no longer includes itsdefault.nixfile.src = ./.entries that unintentionally include their own.nixfiles #301014Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)