Skip to content

postgresqlPackages.pgvecto-rs: 0.2.1 -> 0.3.0#321617

Merged
happysalada merged 1 commit intoNixOS:masterfrom
diogotcorreia:pgvecto-rs-0.3.0
Sep 24, 2024
Merged

postgresqlPackages.pgvecto-rs: 0.2.1 -> 0.3.0#321617
happysalada merged 1 commit intoNixOS:masterfrom
diogotcorreia:pgvecto-rs-0.3.0

Conversation

@diogotcorreia
Copy link
Member

@diogotcorreia diogotcorreia commented Jun 21, 2024 •
edited
Loading

Description of changes

https://github.com/tensorchord/pgvecto.rs/releases/tag/v0.3.0

However, this needs rustc 1.79, so it's failing to build.
Waiting for #320250

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 21, 2024
@ofborg ofborg bot requested review from esclear and happysalada June 21, 2024 23:09
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 21, 2024
@happysalada
Copy link
Contributor

happysalada commented Jun 21, 2024

This looks good, feel free to ping me again when 1.79 lands on master

@diogotcorreia diogotcorreia mentioned this pull request Jun 22, 2024
Merged
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@happysalada
Copy link
Contributor

happysalada commented Jul 16, 2024

Now that 1.79 is in, this should be good to go.
Do you have time to do a quick nixpkgs-review or local test by any chance ?

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Jul 16, 2024

@happysalada I was waiting for it to be available in master, but I can rebase it on staging if you prefer

@happysalada
Copy link
Contributor

happysalada commented Jul 17, 2024

You are completely right here, lets wait for it to land on master its just easier.

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Jul 29, 2024 •
edited
Loading

Rust 1.79 seems to already be in master, but perhaps we should only merge this after Immich supports 0.3.0?
See immich-app/immich#11091

Especially relevant since #324127 requires this package.

EDIT: Keeping it as draft for now due to this.

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Jul 30, 2024

I've rebased this on master and it builds now. I had to do a small change to buildPgrxExtension since upstream removed the pg_test feature from their crate.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 30, 2024
@happysalada
Copy link
Contributor

happysalada commented Jul 30, 2024 •
edited
Loading

The PR looks good but youre right we should probably wait for immich support before merging.

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Aug 13, 2024

Immich will support pgvecto-rs 0.3.0 in the next release: immich-app/immich#11624

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Aug 14, 2024

https://github.com/immich-app/immich/releases/tag/v1.112.0
Immich 1.112.0 released with support for this. Marking as ready

@diogotcorreia diogotcorreia marked this pull request as ready for review August 14, 2024 16:43
@happysalada
Copy link
Contributor

happysalada commented Aug 14, 2024

Should we wait until the updated of immich gets merged ?

@esclear
Copy link
Contributor

esclear commented Aug 15, 2024

Should we wait until the updated of immich gets merged ?

That seems reasonable to me.

@happysalada happysalada merged commit 2232cae into NixOS:master Sep 24, 2024
@diogotcorreia diogotcorreia deleted the pgvecto-rs-0.3.0 branch September 2, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esclear esclear Awaiting requested review from esclear

@happysalada happysalada Awaiting requested review from happysalada

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@diogotcorreia @happysalada @esclear @wegank