[Backport staging-24.05] haskellPackages: Pass ghc-options in generic-builder when cross-compiling#321255
Merged
vcunat merged 1 commit intostaging-24.05from Jul 27, 2024
Merged
Conversation
…ling The following sequence of operations loses ghc-options: Setup.hs configure --ghc-options Setup.hs build --with-ghc=... This is described in [1]. The fix is simple: Don't pass --with-ghc in the build phase. The values are taken from the configure step anyway. This seems to have been introduced all the way back in 64ec4dd about 8 years ago for unknown reasons. Resolves #286285 [1]: haskell/cabal#10069 (cherry picked from commit 5dbf665)
github-actions
bot
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
13 tasks
Member
|
I'm a little concerned here since we don't test as much cross stuff in our Hydra jobsets. Maybe we should wait a little with this? |
Contributor
|
I wondered the same, test coverage is certainly not high. Although.. I'd assume the risk to be rather low. The |
ofborg
bot
added
6.topic: cross-compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
staging-24.05, triggered by a label in #317181.