Skip to content

[Backport release-24.05] llvmPackages_{12,13,14,15,16,17,18,git}: Allow overriding dependencies #321144

Merged
RossComputerGuy merged 1 commit intorelease-24.05from
backport-320261-to-release-24.05
Jun 21, 2024
Merged

[Backport release-24.05] llvmPackages_{12,13,14,15,16,17,18,git}: Allow overriding dependencies #321144
RossComputerGuy merged 1 commit intorelease-24.05from
backport-320261-to-release-24.05

Conversation

@github-actions
Copy link
Contributor

Bot-based backport to release-24.05, triggered by a label in #320261.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

... consistently.

Further to #307211, allow overriding arguments through llvmPackages.override.

This makes it possible to override any dependency of LLVM or
clang by overriding it on `llvmPackages.override { <dependency> = ...; }`.

This is useful in development or customization where sometimes it is
desirable to turn features on or off.

Without this patch the only way to for example override ncurses was to
do `overriddenLLVM = llvmPackages.llvm.override { ncurses }`, but then
you would have to thread `overriddenLLVM` as dependencies into clang and
other packages, which results in quite a difficult expression to write
correctly in cross compilation scenarios.

Signed-off-by: Peter Waller <[email protected]>
(cherry picked from commit 40a7f21)
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 20, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 21, 2024
@RossComputerGuy RossComputerGuy merged commit 201ed88 into release-24.05 Jun 21, 2024
@RossComputerGuy RossComputerGuy deleted the backport-320261-to-release-24.05 branch June 21, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants