Revive multiple outputs for Haskell packages.#32112
Conversation
…ltiple-out"" This reverts commit 89f5d52.
|
@peti: through your |
|
Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/pr-32112. |
|
41 failing looks pretty good :D |
|
@peti I went through all of failures and they are not related to this PR. What else is missing to merge this? |
|
It would be great if someone could test whether functions like |
|
|
Has anyone tested ghcWithHoogle?
|
|
|
@peti See above! |
|
Could not this mass rebuild have gone via staging? I had to revert it in my local checkout just to deploy hydra without building ghc myself. |
|
I think it had its Hydra job, but staging got merged into master in the meantime... |
|
Oh, well, it happens… |
|
Problem: output cycle in |
|
There are apparently also a few Linux regressions due to this PR: https://hydra.nixos.org/eval/1415828?filter=linux&compare=1415796&full=#tabs-now-fail |
|
The cycles between out and bin are caused by #25537 |
|
|
|
@peti I will fix this today. |
|
I thought it was fixed already? I'm a little disappointed, to be honest. This is the second time this PR has completely broken the Haskell infrastructure and it seems pretty obvious that no-one has ever used this code before. This does not inspire confidence. |
I beg your pardon? The expectation that |
|
@peti did you read the comment next to yours that shows that? |
|
I am sorry, but I don't follow. Which comment are you referring to? And what exactly does that comment show? |
|
@peti This was tested before the PR was opened. I can replicate your example quite happily on my branch: That it's broken on master is annoying, but it's not due to this being untested. |
|
@nc6, are you sure that you're actually building the branch you intend to build? I.e. does the |
|
Can confirm this works on master: |
|
Right, |
|
Ah sry didn't notice your revert, fails with: |
|
Oh, darn. Yeah, if I try with |
|
@nc6 I'll give this another try |
|
I have found the issue, |
|
Fixed! Only darwin left: #32082 (comment) |
Incorporates fix to ghcWithPackages from domenkozar.