python3Packages.tree-sitter-grammars: init at 0.22.5#320783
Merged
fricklerhandwerk merged 4 commits intoNixOS:stagingfrom Apr 2, 2025
Merged
python3Packages.tree-sitter-grammars: init at 0.22.5#320783fricklerhandwerk merged 4 commits intoNixOS:stagingfrom
fricklerhandwerk merged 4 commits intoNixOS:stagingfrom
Conversation
sarcasticadmin
commented
Jun 18, 2024
pkgs/development/python-modules/tree-sitter-grammars/default.nix
Outdated
Show resolved
Hide resolved
6937418 to
253c53f
Compare
253c53f to
1ff067a
Compare
1ff067a to
fe9e96c
Compare
4eeaa9e to
8c63440
Compare
8c63440 to
0550b06
Compare
0550b06 to
5947cdb
Compare
5947cdb to
ea460ca
Compare
mightyiam
reviewed
Jun 20, 2024
|
For the record, this is already ready for review, even though it's marked as draft. |
ea460ca to
d3890e6
Compare
be0a31b to
93a9562
Compare
mightyiam
reviewed
Jun 20, 2024
93a9562 to
615c75b
Compare
13 tasks
13 tasks
b11917a to
d92aaca
Compare
d92aaca to
0e1596f
Compare
0e1596f to
b69b50a
Compare
fricklerhandwerk
approved these changes
Mar 29, 2025
maintainers/maintainer-list.nix
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
Stray newline
Contributor
There was a problem hiding this comment.
Thank you, it should be fixed now.
b69b50a to
5f355d2
Compare
Contributor
|
I think this is good and will merge it in the next few days. If anyone has complaints after that, we're here to fix forward. |
Co-authored-by: Robert James Hernandez <[email protected]> Co-authored-by: Yifei Sun <[email protected]> Co-authored-by: Ali Jamadi <[email protected]> Co-authored-by: yakampe <[email protected]> Co-authored-by: GetPsyched <[email protected]> Co-authored-by: Adrien Faure <[email protected]> Co-authored-by: Shahar "Dawn" Or <[email protected]> python3Packages.tree-sitter-grammars: Filtering uncompatible grammars py-tree-sitter is still not up to date to latest tree-sitter (0.25). py-tree-sitter gets tree-sitter from a submodule which is at version 0.24. Therefore all grammar with a langage version greater that 14 are not compatible (language version is most of the time commited into the source of the grammar, so we don't have a lot of control over it). For now it concerns two grammars: - sql grammar gets generated during the build and therefore ends up with the latest language version (15) not compatible with py-tree-sitter - templ grammar is already at version 15 in the upstream source.
5f355d2 to
7b1f63b
Compare
|
Congratulations! |
3 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As request in ngi-nix/ngipkgs#139
This generates a python binding package for each tree-sitter-grammar that exists in
tree-sitter.builtGrammars.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.