Skip to content

consul-alerts: remove#320594

Closed
katexochen wants to merge 1 commit intoNixOS:masterfrom
katexochen:consule-alerts/remove
Closed

consul-alerts: remove#320594
katexochen wants to merge 1 commit intoNixOS:masterfrom
katexochen:consule-alerts/remove

Conversation

@katexochen
Copy link
Contributor

@katexochen katexochen commented Jun 17, 2024

Description of changes

Superseds #318257

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Paul Meyer <[email protected]>
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 17, 2024
@katexochen katexochen requested review from leona-ya and nh2 June 18, 2024 05:52
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nh2 Feel free to intervene if you feel this package is still needed :)

@katexochen
Copy link
Contributor Author

Oh, this is also part of the consul nixos module...

@Aleksanaa Aleksanaa added the 9.needs: maintainer feedback Waiting for the package maintainer to respond. label Jun 18, 2024
@nh2
Copy link
Contributor

nh2 commented Jun 18, 2024

@katexochen Yeah this is an annoying situation. I use consul-alerts in production, and haven't found a great alternative to it yet.

It really is a shame, because conceptually the project is great and it's very useful for internal production monitoring.

I do not mind its removal from nixpkgs; in the worst case I'll vendor the derivation until I've found a good replacement.

@nh2 nh2 mentioned this pull request Jun 18, 2024
13 tasks
@katexochen
Copy link
Contributor Author

All good, I think you actively using it is enough reason to keep it. :)

@katexochen katexochen closed this Jun 18, 2024
@katexochen katexochen deleted the consule-alerts/remove branch June 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 9.needs: maintainer feedback Waiting for the package maintainer to respond. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants