yarn2nix: avoid appearing to include src#320578
Merged
infinisil merged 1 commit intoNixOS:masterfrom Jun 17, 2024
Merged
Conversation
This expression didn't actually include src, but it looked like it did. Make it like others by using a fileset (for instance, NixOS#319883)
github-actions
bot
added
the
6.topic: nodejs
ofborg
bot
added
10.rebuild-darwin: 1-10
infinisil
approved these changes
Jun 17, 2024
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
Really nice to see the kind of mess we can avoid with lib.fileset :D
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This expression didn't actually include src, but it looked like it did. Make it like others by using a fileset (for instance, #319883)
I verified that this didn't do anything by diffing the two derivation and seeing no difference.
src = ./.entries that unintentionally include their own.nixfiles #301014Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)