libtiff: Add patch to fix missing Lerc in libtiff-4.pc#320105
Merged
nh2 merged 1 commit intoNixOS:stagingfrom Jun 16, 2024
Merged
libtiff: Add patch to fix missing Lerc in libtiff-4.pc#320105nh2 merged 1 commit intoNixOS:stagingfrom
Lerc in libtiff-4.pc#320105nh2 merged 1 commit intoNixOS:stagingfrom
Conversation
nh2
added a commit
to nh2/static-haskell-nix
that referenced
this pull request
Jun 15, 2024
ofborg
bot
added
11.by: package-maintainer
l0b0
reviewed
Jun 15, 2024
Contributor
l0b0
left a comment
l0b0
left a comment
There was a problem hiding this comment.
Code LGTM; thank you for the thorough work! Some caveats/questions:
- The patch hasn't been accepted upstream yet. It might be prudent to wait for that to happen before adding it.
- Which situation does this fix in nixpkgs? Is Lerc in nixpkgs' libtiff already not working? (If so, which commit broke it?) Another way to think about it is: would it be possible to add a test for this to demonstrate what the patch fixes?
- Does this remove the need for
lercinbuildInputs? Is it equivalent? Complementary? Or just not related to that line? - We'll probably want a "TODO" comment marking this for
git revertonce the upstream patch is in the latest release of libtiff.
Contributor
Author
|
This was accidentally closed by nh2/static-haskell-nix@4c9cf63 with my commit message Looks like Github is way too agressive, parsing that as Reopening. |
nh2
force-pushed
the
libtiff-static-lerc-pc-file
branch
from
7f937d0 to
762abd8
Compare
Contributor
Author
Maybe for a while, yes. It's quite certainly correct to do this, as I believe the only reason it isn't in their autoconf build system is that either they forgot it, or because in contrast to CMake, autoconf cannot check for the version number in which
This fixes In normal
Unrelated to that line;
Done. |
l0b0
approved these changes
Jun 16, 2024
Yarny0
added a commit
to Yarny0/nixpkgs
that referenced
this pull request
Sep 18, 2024
Release notes: https://libtiff.gitlab.io/libtiff/releases/v4.7.0.html Fixed CVEs: * CVE-2023-52356 https://gitlab.com/libtiff/libtiff/-/issues/622 * CVE-2024-7006 https://gitlab.com/libtiff/libtiff/-/issues/624 This update incorporates the `lerc` dependency declaration, therefore we drop the corresponding patch, c.f. https://gitlab.com/libtiff/libtiff/-/merge_requests/633 NixOS#320105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Found in static-haskell-nix. This should help
pkgsStaticequally.Upstream PR is: https://gitlab.com/libtiff/libtiff/-/merge_requests/633
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
@NixOS/geospatial