python3.tests.nix-pythonprefix-mypy: Avoid unnecessary rebuilds#319888
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Jun 15, 2024
Merged
python3.tests.nix-pythonprefix-mypy: Avoid unnecessary rebuilds#319888mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt merged 1 commit intoNixOS:masterfrom
Conversation
E.g. when the Nix is changed
github-actions
bot
added
the
6.topic: python
37 tasks
philiptaron
approved these changes
Jun 14, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
$ diff -r -u4 /nix/store/gq6b77q97cpsbxs8rx070wfl533s4lpw-typeddep /nix/store/rsbc8gc512fmsamc8n383x97ixf0sics-source
Only in /nix/store/gq6b77q97cpsbxs8rx070wfl533s4lpw-typeddep: default.nix
I had to build this specific derivation with this command, btw:
nix-build --expr 'let p = import ./. { }; in p.python3.pkgs.callPackage pkgs/development/interpreters/python/tests/test_nix_pythonprefix/typeddep/default.nix { }'
Member
Author
|
I mentioned the attribute that builds this in the description :P |
Contributor
The derivation mentioned definitely causes this package to be built, but it doesn't directly show it, so my workflow of |
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
|
Here's a hack to print excluded files by default :P: diff --git a/lib/fileset/default.nix b/lib/fileset/default.nix
index bb327226731e..32bfcf21ecf6 100644
--- a/lib/fileset/default.nix
+++ b/lib/fileset/default.nix
@@ -123,6 +123,7 @@ let
isPath
pathExists
seq
+ trace
typeOf
nixVersion
;
@@ -473,6 +474,8 @@ in {
- Set `fileset` to a file set that cannot contain files outside the `root` (${toString root}). This could change the files included in the result.''
else
seq sourceFilter
+ trace "lib.fileset.toSource: These files are excluded:"
+ seq (_printFileset (_difference (_singleton root) fileset))
cleanSourceWith {
name = "source";
src = root; |
wegank
added
the
12.approvals: 1
mweinelt
approved these changes
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
E.g. when the Nix is changed, see #301014
Things done
python3.tests.nix-pythonprefix-mypyon x86_64-linuxAdd a 👍 reaction to pull requests you find important.