vue-language-server: init at 2.0.21 by friedow · Pull Request #319134 · NixOS/nixpkgs

friedow · 2024-06-11T20:50:51Z

Description of changes

This adds the official vue-language-server (called @vue/language-server in npm) package. This is needed for example for the neovim lsp integration (https://github.com/vuejs/language-tools?tab=readme-ov-file#community-integration).

Furethermore this PR removes the deprecated nodePackages.@volar/vue-language-server.

Things done

Add a 👍 reaction to pull requests you find important.

a-kenji · 2024-06-11T23:19:39Z

Result of nixpkgs-review pr 319134 run on x86_64-linux 1

5 packages failed to build:

lv_img_conv
modrinth-app
modrinth-app-unwrapped
postcss-cli
wrangler

42 packages built:

akkoma-frontends.akkoma-fe
balena-cli
bat-extras.prettybat
code-server
commitlint
concurrently
create-cycle-app
discourse
discourseAllPlugins
documenso
emanote
emanote.data
emanote.doc
emojione
fast-cli
image_optim
joplin
lemmy-ui
lessc
lighthouse
nodehun
openvscode-server
pscid
styx
styx.lib
styx.themes
theLoungePlugins.plugins.closepms
theLoungePlugins.themes.flat-blue
theLoungePlugins.themes.flat-dark
uppy-companion
vimPlugins.coc-docker
vimPlugins.coc-explorer
vimPlugins.coc-go
vimPlugins.coc-metals
vimPlugins.coc-pyright
vimPlugins.coc-sh
vimPlugins.coc-stylelint
vimPlugins.coc-sumneko-lua
vimPlugins.coc-tslint
vimPlugins.coc-vetur
vscode-extensions.rust-lang.rust-analyzer
wasm-text-gen

lelgenio · 2024-06-12T00:45:01Z

Could this be done using buildNpmPackage?

a-kenji · 2024-06-12T07:11:18Z

Result of nixpkgs-review pr 319134 run on x86_64-linux 1

2 packages marked as broken and skipped:

zerobin
zerobin.dist

5 packages failed to build:

lv_img_conv
modrinth-app
modrinth-app-unwrapped
postcss-cli
wrangler

44 packages built:

akkoma-frontends.akkoma-fe
balena-cli
bat-extras.prettybat
code-server
commitlint
concurrently
create-cycle-app
discourse
discourseAllPlugins
documenso
emanote (haskellPackages.emanote)
emanote.data (haskellPackages.emanote.data)
emanote.doc (haskellPackages.emanote.doc)
emojione
fast-cli
haskellPackages.tailwind
haskellPackages.tailwind.doc
image_optim
joplin
lemmy-ui
lessc
lighthouse
nodehun
openvscode-server
pscid
styx
styx.lib
styx.themes
theLoungePlugins.plugins.closepms
theLoungePlugins.themes.flat-blue
theLoungePlugins.themes.flat-dark
uppy-companion
vimPlugins.coc-docker
vimPlugins.coc-explorer
vimPlugins.coc-go
vimPlugins.coc-metals
vimPlugins.coc-pyright
vimPlugins.coc-sh
vimPlugins.coc-stylelint
vimPlugins.coc-sumneko-lua
vimPlugins.coc-tslint
vimPlugins.coc-vetur
vscode-extensions.rust-lang.rust-analyzer
wasm-text-gen

a-kenji

LGTM, tested basic ipc of the lsp.

a-kenji · 2024-06-12T07:16:57Z

That could be a good way do build it @lelgenio.
It seems it is in the npm registry: https://www.npmjs.com/package/@vue/language-server

a-kenji · 2024-06-12T07:20:32Z

@friedow
Please change the commit message and title of the pr to:

nodePackages.@vue/language-server: init at [VERSION]

friedow · 2024-06-12T07:38:35Z

Should I move this into a 'standalone package' build with buildNpmPackage or not? This would differ from the other nodePackages, is that fine?
I think the packages that are failing to build fail because the generate.sh script for nodePackages updates the package.lock file. This effectively updates all nodePackages, resulting in broken packages that depend on those. How do we deal with something like that in nixpkgs?
The question from my note above is still open: This package should replace @volar/vue-language-server. How do we deal with deprecations in nixpkgs? Should I remove @volar/vue-language-server in another PR?

SuperSandro2000 · 2024-06-12T07:42:20Z

This would differ from the other nodePackages, is that fine?

We don't want any new nodePackages as they are a pain to update and maintain.

This effectively updates all nodePackages, resulting in broken packages that depend on those. How do we deal with something like that in nixpkgs?

We don't, nodePackages is broken by design and if you care enough about a package in it, that it being broken is a problem, it should be packaged separately.

This package should replace @volar/vue-language-server. How do we deal with deprecations in nixpkgs? Should I remove @volar/vue-language-server in another PR?

Yes, same PR. See the readme in nodePackages and aliases file for node.

SuperSandro2000

See above comment

friedow · 2024-06-12T07:46:53Z

@SuperSandro2000 thanks for clarifying :), I'll package this as a separate package using buildNpmPackage then. Furthermore, in the same PR I'll remove @volar/vue-language-server. Will do that later today ;).

friedow · 2024-06-14T21:42:42Z

@SuperSandro2000, @a-kenji , @lelgenio I've updated this PR according to your suggestions. This PR now includes vue-language-server (based on @vue/language-server in npm) as a standalone package build with buildNpmPackage. Furthermore, it removes the deprecated nodepackages.@volar/vue-language-server.
Would you take another look?

lelgenio · 2024-06-14T22:14:28Z

You could add an alias in pkgs/development/node-packages/aliases.nix, so it still works for people using nodePackages."@volar/vue-language-server".

lelgenio · 2024-06-14T23:49:01Z

Result of nixpkgs-review pr 319134 run on x86_64-linux 1

2 packages marked as broken and skipped:

zerobin
zerobin.dist

6 packages failed to build:

lv_img_conv
modrinth-app
modrinth-app-unwrapped
postcss-cli
vscode-js-debug
wrangler

48 packages built:

akkoma-frontends.akkoma-fe
balena-cli
bat-extras.prettybat
code-server
commitlint
concurrently
create-cycle-app
discourse
discourseAllPlugins
documenso
emanote (haskellPackages.emanote)
emanote.data (haskellPackages.emanote.data)
emanote.doc (haskellPackages.emanote.doc)
emojione
fast-cli
haskellPackages.tailwind
haskellPackages.tailwind.doc
image_optim
imapnotify
joplin
lemmy-ui
lessc
lighthouse
nodehun
openvscode-server
pscid
styx
styx.lib
styx.themes
theLoungePlugins.plugins.closepms
theLoungePlugins.plugins.giphy
theLoungePlugins.themes.flat-blue
theLoungePlugins.themes.flat-dark
uppy-companion
vimPlugins.coc-clangd
vimPlugins.coc-docker
vimPlugins.coc-explorer
vimPlugins.coc-go
vimPlugins.coc-metals
vimPlugins.coc-pyright
vimPlugins.coc-sh
vimPlugins.coc-stylelint
vimPlugins.coc-sumneko-lua
vimPlugins.coc-tslint
vimPlugins.coc-vetur
vscode-extensions.rust-lang.rust-analyzer
vue-language-server
wasm-text-gen

pkgs/by-name/vu/vue-language-server/package.nix

friedow · 2024-06-15T10:42:04Z

@lelgenio both done: aliases are added, nixfmt-rfc-style was executed

lelgenio

pkgs/development/node-packages/overrides.nix still has a reference to the old volar package

friedow · 2024-06-17T16:37:38Z

@SuperSandro2000 could you review again?

friedow · 2024-06-21T08:32:08Z

@SuperSandro2000, I dont wanna annoy you but could you review again please?

not responsive

Artturin · 2024-10-20T02:42:37Z

pkgs/development/node-packages/node-env.nix

    let
      extraArgs = removeAttrs args [ "name" "dependencies" "buildInputs" "dontStrip" "dontNpmInstall" "preRebuild" "unpackPhase" "buildPhase" "meta" ];
    in
-    stdenv.mkDerivation (finalAttrs: {


@Scrumplex this reverted your 4549773
Node2nix generates this file

friedow mentioned this pull request Jun 11, 2024

Add @vue/typescript-plugin to nodePackages #303707

Closed

13 tasks

friedow requested a review from a-kenji June 11, 2024 20:57

friedow self-assigned this Jun 11, 2024

ofborg bot requested a review from Luflosi June 11, 2024 21:21

ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 11, 2024

github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Jun 11, 2024

a-kenji approved these changes Jun 12, 2024

View reviewed changes

friedow changed the title ~~pkgs: add nodePackages.@vue/language-server~~ nodePackages.@vue/language-server: init at 2.0.21 Jun 12, 2024

SuperSandro2000 previously requested changes Jun 12, 2024

View reviewed changes

friedow force-pushed the pkgs/@vue/language-server branch from e9fe2ac to f08fe7b Compare June 14, 2024 21:29

friedow changed the title ~~nodePackages.@vue/language-server: init at 2.0.21~~ vue-language-server: init at 2.0.21 Jun 14, 2024

friedow requested review from SuperSandro2000 and a-kenji June 14, 2024 21:43

ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 14, 2024

lelgenio reviewed Jun 14, 2024

View reviewed changes

pkgs/by-name/vu/vue-language-server/package.nix Outdated Show resolved Hide resolved

vue-language-server: init at 2.0.21

f77f9f5

friedow force-pushed the pkgs/@vue/language-server branch from f08fe7b to e804162 Compare June 15, 2024 10:39

friedow requested a review from lelgenio June 15, 2024 10:45

a-kenji approved these changes Jun 15, 2024

View reviewed changes

lelgenio approved these changes Jun 15, 2024

View reviewed changes

wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jun 15, 2024

lelgenio suggested changes Jun 16, 2024

View reviewed changes

nodePackages.@volar/vue-language-server: remove deprecated package

6443d95

friedow force-pushed the pkgs/@vue/language-server branch from e804162 to 6443d95 Compare June 16, 2024 06:39

friedow requested a review from lelgenio June 16, 2024 06:39

wegank removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jun 16, 2024

lelgenio approved these changes Jun 16, 2024

View reviewed changes

friedow added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jun 16, 2024

Lassulus merged commit fe3909b into NixOS:master Jun 25, 2024

This was referenced Jun 26, 2024

Build failure: wrangler #322571

Closed

wrangler: init at 3.62.0 #322573

Merged

yzx9 mentioned this pull request Jul 3, 2024

Update request: nodePackages_latest.volar 1.6.5 → 2.0.13 #309125

Closed

1 task

Artturin reviewed Oct 20, 2024

View reviewed changes

Artturin mentioned this pull request Oct 20, 2024

aliases: keep the utillinux alias until node2nix is phased out #349783

Merged

13 tasks

wbondanza-devoteam mentioned this pull request Jan 23, 2025

vue-typescript-plugin: init at 2.2.0 #374299

Merged

13 tasks

Uh oh!

Conversation

friedow commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

a-kenji commented Jun 11, 2024

Uh oh!

lelgenio commented Jun 12, 2024

Uh oh!

a-kenji commented Jun 12, 2024

Uh oh!

a-kenji left a comment

Choose a reason for hiding this comment

Uh oh!

a-kenji commented Jun 12, 2024

Uh oh!

a-kenji commented Jun 12, 2024

Uh oh!

friedow commented Jun 12, 2024

Uh oh!

SuperSandro2000 commented Jun 12, 2024

Uh oh!

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Uh oh!

friedow commented Jun 12, 2024

Uh oh!

friedow commented Jun 14, 2024

Uh oh!

lelgenio commented Jun 14, 2024

Uh oh!

lelgenio commented Jun 14, 2024

Uh oh!

Uh oh!

friedow commented Jun 15, 2024

Uh oh!

lelgenio left a comment

Choose a reason for hiding this comment

Uh oh!

friedow commented Jun 17, 2024

Uh oh!

friedow commented Jun 21, 2024

Uh oh!

Artturin Oct 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

friedow commented Jun 11, 2024 •

edited

Loading

Artturin Oct 20, 2024 •

edited

Loading