Skip to content

docker: migrate to buildGoModule#318922

Merged
drupol merged 1 commit intoNixOS:masterfrom
Gerg-L:docker2
Jun 19, 2024
Merged

docker: migrate to buildGoModule#318922
drupol merged 1 commit intoNixOS:masterfrom
Gerg-L:docker2

Conversation

@Gerg-L
Copy link
Contributor

@Gerg-L Gerg-L commented Jun 10, 2024

Description of changes

part of: #318069

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 11, 2024
@katexochen katexochen mentioned this pull request Jun 11, 2024
Closed
35 tasks
@vdemeester
Copy link
Member

vdemeester commented Jun 11, 2024

Result of nixpkgs-review pr 318922 run on x86_64-linux 1

1 package failed to build:
  • devcontainer
22 packages built:
  • airlift
  • airlift.dist
  • apptainer
  • apptainer-overriden-nixos
  • charliecloud
  • docker (docker_24)
  • docker-client
  • docker-gc
  • docker-sbom
  • docker_25
  • docker_26
  • fn-cli
  • nvidia-docker
  • pipework
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

vdemeester
vdemeester approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@vdemeester vdemeester added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 11, 2024
msanft
msanft approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The devcontainer build seems to be broken, but is unrealted to this PR and also broken on main

@msanft msanft mentioned this pull request Jun 11, 2024
Merged
13 tasks
@vdemeester
Copy link
Member

vdemeester commented Jun 11, 2024 

@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/axrcfrdihcc90v1sfkfv3s0f6sbkk5p1-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
yarn config v1.22.22
success Set "yarn-offline-mirror" to "/nix/store/7q311bg1n8v5zgbrkjxx336zycm38ff9-offline".
Done in 0.17s.
yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[] 0/554[] 3/554[] 8/554[] 13/554[] 16/554[] 18/554[] 20/554[] 26/554[] 29/554[] 33/554[] 37/554[] 40/554[] 43/554[] 49/554[] 51/554[] 55/554[] 57/554[] 58/554[] 63/554[] 71/554[] 81/554[] 90/554[] 97/554[] 101/554[] 102/554[] 104/554[] >
[] 554/554[] 0/589[] 0/16489[] 510/16489[] 930/16489[] 1314/16489[] 1568/16489[] 1702/16489[] 1830/16489[] 1960/16489[] 2051/16489[] 2248/16489[] 2457/16489[] 2585/16489[] 2777/16489[] 3010/16489[] 3126/16489[] 3240/16489[] 3368/16489[] >

error /build/source/node_modules/esbuild: Command failed.
Exit code: 127
Command: node install.js
Arguments: 
Directory: /build/source/node_modules/esbuild
Output:
/bin/sh: node: not found
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

This is the "weird" failure of devcontainer. I have no idea why it fails but it does not seem to be related at al to this update so I think it should be fine to merge. Even on master, devcontainer doesn't build (same error with nix build .#devcontainer).

SuperSandro2000
SuperSandro2000 reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gerg-L Gerg-L added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 11, 2024
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Jun 11, 2024

I'm assuming Sandro misclicked review instead of approve :D

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 3+ This PR was reviewed and approved by three or more persons. labels Jun 11, 2024
@Gerg-L Gerg-L mentioned this pull request Jun 12, 2024
Merged
13 tasks
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Jun 12, 2024

devcontainer was just missing nodejs in nativeBuildInputs, fixed it

@Gerg-L
Copy link
Contributor Author

Gerg-L commented Jun 19, 2024

Result of nixpkgs-review pr 318922 run on x86_64-linux 1

23 packages built:
  • airlift
  • airlift.dist
  • apptainer
  • apptainer-overriden-nixos
  • charliecloud
  • devcontainer
  • docker
  • docker-client
  • docker-gc
  • docker-sbom
  • docker_25
  • docker_26
  • fn-cli
  • nvidia-docker
  • pipework
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

@ofborg ofborg bot requested a review from vdemeester June 19, 2024 03:24
@msanft msanft requested a review from SuperSandro2000 June 19, 2024 11:08
@drupol drupol merged commit 0bfc853 into NixOS:master Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msanft msanft msanft approved these changes

@teutat3s teutat3s Awaiting requested review from teutat3s

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@periklis periklis Awaiting requested review from periklis

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

+1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gerg-L @vdemeester @SuperSandro2000 @msanft @drupol @wegank