ssm-session-manager-plugin: migrate to buildGoModule#318850
Merged
Mic92 merged 2 commits intoNixOS:masterfrom Jul 21, 2024
Merged
ssm-session-manager-plugin: migrate to buildGoModule#318850Mic92 merged 2 commits intoNixOS:masterfrom
Mic92 merged 2 commits intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
msanft
force-pushed
the
ssm-session-manager-plugin/build-go-module
branch
from
73d037a to
35bab6a
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
35 tasks
katexochen
force-pushed
the
ssm-session-manager-plugin/build-go-module
branch
from
35bab6a to
d2f65e2
Compare
wegank
added
the
2.status: merge conflict
katexochen
force-pushed
the
ssm-session-manager-plugin/build-go-module
branch
from
d2f65e2 to
dd03ac7
Compare
ofborg
bot
removed
the
2.status: merge conflict
Contributor
|
Result of 3 packages built:
|
malt3
approved these changes
Jul 11, 2024
Member
|
Please perform the move to by-name in a separate commit so Git can detect the rename and e.g. |
amarshall
suggested changes
Jul 11, 2024
Member
amarshall
left a comment
amarshall
left a comment
There was a problem hiding this comment.
See also above comment about rename commit. I wasn’t able to fully review changes as the diff is hard to process as a result.
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
katexochen
force-pushed
the
ssm-session-manager-plugin/build-go-module
branch
from
dd03ac7 to
bbb4986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating to
buildGoModulesobuildGoPackagecan be deprecated as per #318069.Also moved to
by-name.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.