Skip to content

vndr: migrate to buildGoModule#318798

Merged
katexochen merged 1 commit intoNixOS:masterfrom
msanft:vndr/build-go-module
Jun 22, 2024
Merged

vndr: migrate to buildGoModule#318798
katexochen merged 1 commit intoNixOS:masterfrom
msanft:vndr/build-go-module

Conversation

@msanft
Copy link
Contributor

@msanft msanft commented Jun 10, 2024

Description of changes

Migrating to buildGoModule so buildGoPackage can be deprecated as per #318069. Project needs an upstream patch to do so, as it does not have a vendor directory, nor is a module.

Also moved to by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft msanft requested a review from katexochen June 10, 2024 13:33
@ofborg ofborg bot requested review from rvolosatovs and vdemeester June 10, 2024 14:45
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 10, 2024
@katexochen katexochen mentioned this pull request Jun 11, 2024
Closed
35 tasks
@vdemeester
Copy link
Member

vdemeester commented Jun 11, 2024

Result of nixpkgs-review pr 318798 run on x86_64-linux 1

1 package built:
  • vndr

@vdemeester
Copy link
Member

vdemeester commented Jun 11, 2024 

@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/axrcfrdihcc90v1sfkfv3s0f6sbkk5p1-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
yarn config v1.22.22
success Set "yarn-offline-mirror" to "/nix/store/7q311bg1n8v5zgbrkjxx336zycm38ff9-offline".
Done in 0.17s.
yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[] 0/554[] 3/554[] 8/554[] 13/554[] 16/554[] 18/554[] 20/554[] 26/554[] 29/554[] 33/554[] 37/554[] 40/554[] 43/554[] 49/554[] 51/554[] 55/554[] 57/554[] 58/554[] 63/554[] 71/554[] 81/554[] 90/554[] 97/554[] 101/554[] 102/554[] 104/554[] >
[] 554/554[] 0/589[] 0/16489[] 510/16489[] 930/16489[] 1314/16489[] 1568/16489[] 1702/16489[] 1830/16489[] 1960/16489[] 2051/16489[] 2248/16489[] 2457/16489[] 2585/16489[] 2777/16489[] 3010/16489[] 3126/16489[] 3240/16489[] 3368/16489[] >

error /build/source/node_modules/esbuild: Command failed.
Exit code: 127
Command: node install.js
Arguments: 
Directory: /build/source/node_modules/esbuild
Output:
/bin/sh: node: not found
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

This is the "weird" failure of devcontainer. I have no idea why it fails but it does not seem to be related at al to this update so I think it should be fine to merge. Even on master, devcontainer doesn't build (same error with nix build .#devcontainer).

@msanft
Copy link
Contributor Author

msanft commented Jun 11, 2024 •
edited
Loading

@vdemeester I think this should've gone to #318922

@vdemeester
Copy link
Member

vdemeester commented Jun 11, 2024

@vdemeester I think this should've gone to #318922

Indeed.. wrong tab.. 🤦🏼

@vdemeester vdemeester added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 11, 2024
katexochen
katexochen requested changes Jun 13, 2024
View reviewed changes
@msanft msanft requested a review from katexochen June 21, 2024 08:21
@msanft msanft force-pushed the vndr/build-go-module branch from a49cc84 to 6312c83 Compare June 21, 2024 08:21
@katexochen katexochen merged commit cbee4ed into NixOS:master Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katexochen katexochen katexochen approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msanft @vdemeester @katexochen