Skip to content

librarian-puppet-go: remove#318787

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
msanft:librarian-puppet-go/build-go-module
Jun 10, 2024
Merged

librarian-puppet-go: remove#318787
doronbehar merged 1 commit intoNixOS:masterfrom
msanft:librarian-puppet-go/build-go-module

Conversation

@msanft
Copy link
Contributor

@msanft msanft commented Jun 10, 2024

Description of changes

Package is not maintained upstream and GH code search doesn't yield any uses of it, so schedule it for removal.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft msanft requested a review from katexochen June 10, 2024 13:07
@katexochen katexochen mentioned this pull request Jun 10, 2024
35 tasks
@SuperSandro2000
Copy link
Member

The project seems to be pretty dead and not so popular, so I would also support removing it.

@msanft msanft force-pushed the librarian-puppet-go/build-go-module branch from 02cc3c5 to 3c4eda0 Compare June 10, 2024 13:45
@msanft msanft changed the title librarian-puppet-go: migrate to buildGoModule librarian-puppet-go: remove Jun 10, 2024
@msanft msanft requested a review from SuperSandro2000 June 10, 2024 13:47
@msanft msanft force-pushed the librarian-puppet-go/build-go-module branch from 3c4eda0 to 02f2ccc Compare June 10, 2024 13:47
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 10, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 10, 2024
@doronbehar doronbehar merged commit 1cfca01 into NixOS:master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants