Skip to content

decibels: init at 46.0#318708

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/decibels/init
Jul 6, 2024
Merged

decibels: init at 46.0#318708
Aleksanaa merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/decibels/init

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Jun 10, 2024

Description of changes

Decibels is a small Libadwaita application that plays audio files

A part of #195280

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 10, 2024
@matteo-pacini
Copy link
Contributor

matteo-pacini commented Jun 10, 2024

@getchoo does not compile on Darwin due to a broken dependency:

Package ‘spidermonkey-115.9.1’ in /Users/admin/.cache/nixpkgs-review/pr-318708/nixpkgs/pkgs/development/interpreters/spidermonkey/common.nix:191 is marked as broken, refusing to evaluate.

It's probably best to mark it as broken for the platform, or just restrict platforms to unix - darwin.

@matteo-pacini matteo-pacini mentioned this pull request Jun 10, 2024
13 tasks
@getchoo getchoo force-pushed the pkgs/decibels/init branch from d91dff9 to e80ea5f Compare June 10, 2024 09:00
@getchoo
Copy link
Member Author

getchoo commented Jun 10, 2024

after taking a look at both upstreams, it doesn't seem neither go out of their way to support platforms besides linux. i think it might be best to just limit support to there

@Aleksanaa Aleksanaa merged commit 6a8ac9e into NixOS:master Jul 6, 2024
@getchoo getchoo deleted the pkgs/decibels/init branch July 6, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants