Skip to content

commit: init at 4.1#318705

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/commit/init
Jul 6, 2024
Merged

commit: init at 4.1#318705
Aleksanaa merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/commit/init

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Jun 10, 2024

Description of changes

Commit is an editor that helps you write better Git and Mercurial commit messages

A part of #195280

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 10, 2024
@matteo-pacini
Copy link
Contributor

matteo-pacini commented Jun 10, 2024

@getchoo Same as the other package: #318708 (comment)

Probably best to mark this as broken on Darwin because of spidermonkey being broken there.

@getchoo getchoo force-pushed the pkgs/commit/init branch from 16e446e to 32398b6 Compare June 10, 2024 09:01
Copy link
Contributor

@fin444 fin444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on x86_64-linux, LGTM

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 19, 2024
@Aleksanaa Aleksanaa merged commit d81e40e into NixOS:master Jul 6, 2024
@getchoo getchoo deleted the pkgs/commit/init branch July 6, 2024 22:26
@donovanglover donovanglover mentioned this pull request Aug 23, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants