kontemplate: migrate to buildGoModule#318627
Merged
katexochen merged 1 commit intoNixOS:masterfrom Jun 17, 2024
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
35 tasks
katexochen
reviewed
Jun 13, 2024
msanft
force-pushed
the
kontemplate/build-go-module
branch
from
4287b32 to
8eb194f
Compare
katexochen
reviewed
Jun 17, 2024
msanft
force-pushed
the
kontemplate/build-go-module
branch
from
8eb194f to
1c3c532
Compare
Signed-off-by: Moritz Sanft <[email protected]>
msanft
force-pushed
the
kontemplate/build-go-module
branch
from
1c3c532 to
21fa9a0
Compare
katexochen
approved these changes
Jun 17, 2024
Contributor
katexochen
left a comment
katexochen
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 318627 run on x86_64-linux 1
1 package built:
- kontemplate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating to
buildGoModulesobuildGoPackagecan be deprecated as per #318069. Project needs an upstream patch to do so, as it does not have a vendor directory, nor is a module.Also moved to
by-name.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.