Merged
Conversation
msanft
added
the
1.severity: security
35 tasks
ofborg
bot
added
8.has: clean-up
AndersonTorres
suggested changes
Jun 9, 2024
AndersonTorres
suggested changes
Jun 11, 2024
Signed-off-by: Moritz Sanft <[email protected]>
msanft
force-pushed
the
guardian-agent/build-go-module
branch
from
b2c5e50 to
422b1fd
Compare
SuperSandro2000
approved these changes
Jun 11, 2024
wegank
added
the
12.approvals: 1
AndersonTorres
approved these changes
Jun 12, 2024
katexochen
added
12.approvals: 2
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-318616-to-release-23.11 origin/release-23.11
cd .worktree/backport-318616-to-release-23.11
git switch --create backport-318616-to-release-23.11
git cherry-pick -x 422b1fdfd0fc57fc5fdb5dfaa2c8e0f49ad78d88 |
1 similar comment
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-318616-to-release-23.11 origin/release-23.11
cd .worktree/backport-318616-to-release-23.11
git switch --create backport-318616-to-release-23.11
git cherry-pick -x 422b1fdfd0fc57fc5fdb5dfaa2c8e0f49ad78d88 |
1 task
Contributor
|
Git push to origin failed for release-24.05 with exitcode 1 |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Guardian-agent relies on a vendored fork of
golang.org/x/cryptothat's seven years old, hasn't been updated since, and thus is vulnerable to numerous security vulnerabilities. Especially as it's security-critical software, we should not keep it in nixpkgs.Also relevant for #318069
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.