grafana-reporter: migrate to buildGoModule#318613
Merged
h7x4 merged 1 commit intoNixOS:masterfrom Jun 21, 2024
Merged
Conversation
Signed-off-by: Moritz Sanft <[email protected]>
github-actions
bot
added
6.topic: nixos
35 tasks
ofborg
bot
added
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 1-10
katexochen
reviewed
Jun 20, 2024
Contributor
katexochen
left a comment
katexochen
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 318613 run on x86_64-linux 1
2 packages blacklisted:
- nixos-install-tools
- tests.nixos-functions.nixos-test
1 package built:
- grafana-reporter
katexochen
approved these changes
Jun 20, 2024
wegank
added
the
12.approvals: 1
h7x4
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating to buildGoModule so buildGoPackage can be deprecated as per #318069.
Also moved to by-name.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.