docopts: migrate to buildGoModule#318612
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Jun 10, 2024
Merged
Conversation
clebs
reviewed
Jun 9, 2024
35 tasks
Signed-off-by: Moritz Sanft <[email protected]>
msanft
force-pushed
the
docopts/build-go-module
branch
from
92625f1 to
6b01739
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Not sure if @con-f-use is still maintaining this package, they are not in the NixOS org (anymore?) and thus weren't pinged by ofborg. |
Contributor
|
Hehe, yeah, I never was in the NixOS org. I'd like to be though. That's the first time I've heard of this PR, looks good. |
Contributor
@con-f-use I think #234293 is the right tread to ask for an (re-)invitation to the org. :) |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating to
buildGoModulesobuildGoPackagecan be deprecated as per #318069. Project needs an upstream patch to do so, as it does not have a vendor directory, nor is a module.Also moved to
by-name.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.