Skip to content

dep2nix: remove#318607

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
msanft:dep2nix/remove
Jul 21, 2024
Merged

dep2nix: remove#318607
Mic92 merged 1 commit intoNixOS:masterfrom
msanft:dep2nix/remove

Conversation

@msanft
Copy link
Contributor

@msanft msanft commented Jun 9, 2024

Description of changes

With the deprecation of buildGoPackage (#318069), deps.nix files become obsolete - thus also this generator.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft
dep2nix: remove
93bfcaf 
Signed-off-by: Moritz Sanft <[email protected]>
@msanft msanft requested a review from katexochen June 9, 2024 19:21
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 9, 2024
@katexochen
Copy link
Contributor

katexochen commented Jun 9, 2024

I think we should at least wait with the dep2nix removal until we remove buildGoPackage. Currently, there are still packages in nixpkgs that have deps files generated with dep2nix. Also we should give downstream users of buildGoPackage/dep2nix time to migrate (which will only start after we set a deprecation notice, as they won't get notified otherwise).

@msanft
Copy link
Contributor Author

msanft commented Jun 9, 2024

I think we should at least wait with the dep2nix removal until we remove buildGoPackage. Currently, there are still packages in nixpkgs that have deps files generated with dep2nix. Also we should give downstream users of buildGoPackage/dep2nix time to migrate (which will only start after we set a deprecation notice, as they won't get notified otherwise).

Perfectly fine to me.

@katexochen katexochen mentioned this pull request Jun 10, 2024
Closed
35 tasks
@katexochen katexochen requested a review from Mic92 June 11, 2024 06:12
@Mic92
Copy link
Member

Mic92 commented Jun 11, 2024 •
edited
Loading

Do we still depend on dep2nix for any of our packages? If worst comes to worse, we can still give downstream packages some hints on how to use dep2nix from older nixos releases.

@msanft
Copy link
Contributor Author

msanft commented Jun 11, 2024

Do we still depend on dep2nix for any of our packages? If worst comes to worse, we can still give downstream packages some hints on how to use dep2nix from older nixos releases.

We don't. And yes, this sounds like a good backup plan. But with the deprecation of Go packages in nixpkgs, this is obsolete anyway.

@Mic92
Copy link
Member

Mic92 commented Jun 11, 2024

Ah. Didn't see there was so much in-progress regarding this: #318069

@Mic92 Mic92 merged commit 43c3b4b into NixOS:master Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katexochen katexochen Awaiting requested review from katexochen

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msanft @katexochen @Mic92 @AndersonTorres