nixos/tests/mpv: adapt to the new mpv wrapper#318588
Merged
marsam merged 2 commits intoNixOS:masterfrom Jun 10, 2024
1sixth:fix-mpv-test
Merged
nixos/tests/mpv: adapt to the new mpv wrapper#318588marsam merged 2 commits intoNixOS:masterfrom 1sixth:fix-mpv-test
marsam merged 2 commits intoNixOS:masterfrom
1sixth:fix-mpv-test
Conversation
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
marsam
reviewed
Jun 9, 2024
Contributor
|
Would you mind adding the following to allow Ofborg to execute this test? diff --git c/pkgs/applications/video/mpv/default.nix i/pkgs/applications/video/mpv/default.nix
index b5672d7afa46..4600cfb48cb6 100644
--- c/pkgs/applications/video/mpv/default.nix
+++ i/pkgs/applications/video/mpv/default.nix
@@ -50,6 +50,7 @@
meson,
mujs,
ninja,
+ nixosTests,
nv-codec-headers-11,
openalSoft,
pipewire,
@@ -60,6 +61,7 @@
speex,
stdenv,
swift,
+ testers,
vapoursynth,
vulkan-headers,
vulkan-loader,
@@ -351,6 +353,18 @@ stdenv'.mkDerivation (finalAttrs: {
wrapper = callPackage ./wrapper.nix { };
scripts = callPackage ./scripts { };
+
+ tests = {
+ inherit (nixosTests) mpv;
+
+ version = testers.testVersion {
+ package = finalAttrs.finalPackage;
+ };
+ pkg-config = testers.hasPkgConfigModules {
+ package = finalAttrs.finalPackage;
+ moduleNames = [ "mpv" ];
+ };
+ };
};@GrahamcOfBorg build mpv-unwrapped.tests |
Co-authored-by: Mario Rodas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The test fails because
wrapMpvhas been removed in #304349.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)