Skip to content

containerpilot: remove#318571

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
msanft:containerpilot/remove
Jun 11, 2024
Merged

containerpilot: remove#318571
Mic92 merged 1 commit intoNixOS:masterfrom
msanft:containerpilot/remove

Conversation

@msanft
Copy link
Contributor

@msanft msanft commented Jun 9, 2024

Description of changes

Schedule the containerpilot package for removal. Most upstream files were not updated in 7 years, and the last docs PR got merged over 3 years ago. Furthermore, the upstream package relies on Go libraries that do not adhere to module versioning and thus an upstream fix is not feasible without a massive patchset. The package in nixpkgs only continued to work as we manually vendor the old dependencies in-tree.

GitHub search revealed a single use of this package: https://github.com/Sanatana-Linux/nixos-config/blob/e1dd35fb74561ed66ff671e84dfb8ee039ce240c/hosts/shared/pkgs/virtualization.nix#L6

Also see #318069

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft msanft requested a review from katexochen June 9, 2024 16:44
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 9, 2024
@katexochen katexochen mentioned this pull request Jun 9, 2024
35 tasks
@katexochen katexochen requested a review from cpcloud June 11, 2024 06:10
@katexochen
Copy link
Contributor

Please rebase to resolve merge conflict.

Signed-off-by: Moritz Sanft <[email protected]>
@msanft msanft force-pushed the containerpilot/remove branch from c228022 to 23930cb Compare June 11, 2024 06:21
@msanft
Copy link
Contributor Author

msanft commented Jun 11, 2024

Please rebase to resolve merge conflict.

done.

@Mic92 Mic92 merged commit 8e5bca2 into NixOS:master Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants