Merged
Conversation
35 tasks
Contributor
|
Please rebase to resolve merge conflict. |
Signed-off-by: Moritz Sanft <[email protected]>
c228022 to
23930cb
Compare
Contributor
Author
done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Schedule the containerpilot package for removal. Most upstream files were not updated in 7 years, and the last docs PR got merged over 3 years ago. Furthermore, the upstream package relies on Go libraries that do not adhere to module versioning and thus an upstream fix is not feasible without a massive patchset. The package in nixpkgs only continued to work as we manually vendor the old dependencies in-tree.
GitHub search revealed a single use of this package: https://github.com/Sanatana-Linux/nixos-config/blob/e1dd35fb74561ed66ff671e84dfb8ee039ce240c/hosts/shared/pkgs/virtualization.nix#L6
Also see #318069
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.