Closed
Conversation
35 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Are you an active user of aws-env? I notice that there's not been any maintenance done to upstream in a long while (which I guess your fetchpatch of your own PR also reveals) |
Contributor
Author
I'm not. Just migrated it for #318069. If you're fine with removal, I'd vouch for that as well. |
msanft
force-pushed
the
aws-env/buildgomodule
branch
from
e4370bc to
dc2823f
Compare
SuperSandro2000
approved these changes
Jun 10, 2024
wegank
added
the
12.approvals: 1
Contributor
|
@msanft I'm going to vote removal, to be honest. Though I appreciate your work, and if anyone complains we can resurrect it. How does that sound to you? I can take care of the removal if need be. :) |
msanft
force-pushed
the
aws-env/buildgomodule
branch
from
dc2823f to
fd00528
Compare
ofborg
bot
added
8.has: clean-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove aws-env, as GH code search doesn't yield any users, and the project seems to be abandoned upstream.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.