Skip to content

sublime-music: 0.12.0 -> 0.12.0-unstable-2024-01-06#318319

Closed
AndersonTorres wants to merge 4 commits intoNixOS:masterfrom
atorres1985-contrib:mpv-extras
Closed

sublime-music: 0.12.0 -> 0.12.0-unstable-2024-01-06#318319
AndersonTorres wants to merge 4 commits intoNixOS:masterfrom
atorres1985-contrib:mpv-extras

Conversation

@AndersonTorres
Copy link
Member

Description of changes

Dealing with the broken sublime-music from #304349.

See the thread at
#304349 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 8, 2024
@AndersonTorres AndersonTorres added awaiting_changes and removed 6.topic: python Python is a high-level, general-purpose programming language. labels Jun 8, 2024
@AndersonTorres AndersonTorres mentioned this pull request Jun 8, 2024
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 8, 2024
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 9, 2024
Also, add myself as maintainer.
@AndersonTorres AndersonTorres changed the title Mpv extras sublime-music: 0.12.0 -> 0.12.0-unstable-2024-01-06 Jun 9, 2024
@AndersonTorres AndersonTorres marked this pull request as ready for review June 9, 2024 15:04
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 9, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2024
@AndersonTorres
Copy link
Member Author

Merge conflicts.

@onny
Copy link
Contributor

onny commented Jun 11, 2024

Are you going to continue this PR?

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Jun 12, 2024

No, I have too many other PRs. Please continue this to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants