Skip to content

go-symbols: migrate to buildGoModule#318272

Merged
katexochen merged 1 commit intoNixOS:masterfrom
luftmensch-luftmensch:go-symbols_update
Jun 9, 2024
Merged

go-symbols: migrate to buildGoModule#318272
katexochen merged 1 commit intoNixOS:masterfrom
luftmensch-luftmensch:go-symbols_update

Conversation

@luftmensch-luftmensch
Copy link
Contributor

Description of changes

Migrating to buildGoModule so buildGoPackage can be deprecated as cited in #318069

Updated also location of the package to reflect the newest standard

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen katexochen mentioned this pull request Jun 8, 2024
35 tasks
@katexochen
Copy link
Contributor

Result of nixpkgs-review pr 318272 run on x86_64-linux 1

1 package built:
  • go-symbols

@ofborg ofborg bot requested a review from vdemeester June 8, 2024 13:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 8, 2024
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM 👍🏼

@katexochen katexochen added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jun 9, 2024
@katexochen katexochen merged commit d75f7c2 into NixOS:master Jun 9, 2024
@luftmensch-luftmensch luftmensch-luftmensch deleted the go-symbols_update branch June 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants