xmonad-log: 0.1.0 -> 0.1.0-unstable-2024-06-14 #318266
Merged
katexochen merged 2 commits intoNixOS:masterfrom Jun 19, 2024
Merged
xmonad-log: 0.1.0 -> 0.1.0-unstable-2024-06-14 #318266katexochen merged 2 commits intoNixOS:masterfrom
katexochen merged 2 commits intoNixOS:masterfrom
Conversation
35 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Aleksanaa
reviewed
Jun 14, 2024
katexochen
force-pushed
the
xmonad-log/mod
branch
2 times, most recently
from
e28f38a to
fa1a2a5
Compare
katexochen
changed the title
Contributor
Author
|
Upstream PR was actually merged. |
h7x4
approved these changes
Jun 16, 2024
Member
h7x4
left a comment
h7x4
left a comment
There was a problem hiding this comment.
Built and tested, basic functionality works as expected.
Diff looks good
katexochen
added
the
12.approvals: 1
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
katexochen
force-pushed
the
xmonad-log/mod
branch
from
fa1a2a5 to
fa547ed
Compare
wegank
removed
the
12.approvals: 1
Contributor
Author
|
Fixed a surplus comma and moved the package to by-name. |
h7x4
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating to
buildGoModulesobuildGoPackagecan be deprecated.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.