Skip to content

protoc-gen-twirp: migrate to buildGoModule#318255

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
katexochen:protoc-gen-twirp/mods
Jun 14, 2024
Merged

protoc-gen-twirp: migrate to buildGoModule#318255
Aleksanaa merged 1 commit intoNixOS:masterfrom
katexochen:protoc-gen-twirp/mods

Conversation

@katexochen
Copy link
Contributor

@katexochen katexochen commented Jun 8, 2024

Description of changes

Migrating to buildGoModule so buildGoPackage can be deprecated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen katexochen mentioned this pull request Jun 8, 2024
35 tasks
@ofborg ofborg bot requested a review from jojosch June 8, 2024 12:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 8, 2024
@Aleksanaa Aleksanaa merged commit e0a105d into NixOS:master Jun 14, 2024
@katexochen katexochen deleted the protoc-gen-twirp/mods branch June 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants