Skip to content

govers: migrate to buildGoModule#318229

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
luftmensch-luftmensch:govers_update
Jun 10, 2024
Merged

govers: migrate to buildGoModule#318229
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
luftmensch-luftmensch:govers_update

Conversation

@luftmensch-luftmensch
Copy link
Contributor

Description of changes

Migrating to buildGoModule so buildGoPackage can be deprecated as cited in #318069

Updated also location of the package to reflect the newest standard

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from urandom2 June 8, 2024 10:03
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 8, 2024
@katexochen
Copy link
Contributor

Result of nixpkgs-review pr 318229 run on x86_64-linux 1

57 packages built:
  • airlift
  • airlift.dist
  • allmark
  • apptainer
  • apptainer-overriden-nixos
  • aws-assume-role
  • aws-assume-role.doc
  • aws-env
  • aws-gate
  • aws-gate.dist
  • charliecloud
  • consul-alerts
  • containerpilot
  • coyim
  • dep2nix
  • devcontainer
  • docker
  • docker-client
  • docker-distribution
  • docker-gc
  • docker-sbom
  • docker_25
  • docker_26
  • docopts
  • fn-cli
  • glock
  • go-symbols
  • go-upower-notify
  • govers
  • grafana_reporter
  • guardian-agent
  • kontemplate
  • librarian-puppet-go
  • mailhog
  • mgmt
  • nex
  • notary
  • nvidia-docker
  • pipework
  • prometheus-dovecot-exporter
  • prometheus-minio-exporter
  • prometheus-surfboard-exporter
  • protoc-gen-twirp
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
  • simplehttp2server
  • singularity
  • singularity-overriden-nixos
  • ssm-session-manager-plugin
  • syncthing-tray
  • tmsu
  • udocker
  • udocker.dist
  • vndr
  • xmonad-log

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/136

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1732

@SuperSandro2000 SuperSandro2000 merged commit f6682cb into NixOS:master Jun 10, 2024
@luftmensch-luftmensch luftmensch-luftmensch deleted the govers_update branch June 10, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants