allmark: migrate to buildGoModule#318220
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Jun 10, 2024
Merged
Conversation
luftmensch-luftmensch
force-pushed
the
allmark_update
branch
from
f327d37 to
f760419
Compare
ofborg
bot
added
11.by: package-maintainer
35 tasks
Contributor
|
Result of 1 package built:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
msanft
approved these changes
Jun 10, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
SuperSandro2000
approved these changes
Jun 10, 2024
Member
|
Please rebase and make sure the description edit is not being lost. |
luftmensch-luftmensch
force-pushed
the
allmark_update
branch
from
f760419 to
ee8381c
Compare
luftmensch-luftmensch
force-pushed
the
allmark_update
branch
from
ee8381c to
f27bd6f
Compare
SuperSandro2000
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrating to
buildGoModulesobuildGoPackagecan be deprecated as cited in #318069Updated also location of the package to reflect the newest standard
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.