Skip to content

buildGoPackage: accept fixed-point function argument#317559

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

buildGoPackage: accept fixed-point function argument#317559
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 5, 2024

Description of changes

Someone asked me why buildGoModule didn't accept (finalAttrs: {}) arguments and I didn't have a good answer for them.

I do this for buildGoPackage first and then buildGoModule.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. label Jun 5, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 5, 2024
@zowoq
Copy link
Contributor

zowoq commented Jun 5, 2024

See #225051 and #234651.

@ghost
Copy link
Author

ghost commented Jun 6, 2024

This change unfortunately degrades performance slightly according to $NIX_SHOW_STATS. There might be a way to get it back by tweaking the internals of buildGoPackage but I don't want to do that for this PR.

@zowoq
Copy link
Contributor

zowoq commented Jun 26, 2024

Please revert the formatting changes.

@zowoq
Copy link
Contributor

zowoq commented Jun 26, 2024

#318069

Actually it looks like we are very close to deprecating buildGoPackage so I'd prefer that we don't merge this PR.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@NickCao
Copy link
Member

NickCao commented Dec 4, 2024

buildGoPackage has been dropped.

@NickCao NickCao closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants