Skip to content

python311Packages.forbiddenfruit: refactor and remove nose#317170

Merged
fabaff merged 3 commits intoNixOS:masterfrom
natsukium:forbiddenfruit
Jun 9, 2024
Merged

python311Packages.forbiddenfruit: refactor and remove nose#317170
fabaff merged 3 commits intoNixOS:masterfrom
natsukium:forbiddenfruit

Conversation

@natsukium
Copy link
Member

@natsukium natsukium commented Jun 4, 2024

Description of changes

part of #311054

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 4, 2024
@natsukium natsukium mentioned this pull request Jun 4, 2024
Closed
@natsukium
Copy link
Member Author

natsukium commented Jun 4, 2024

Result of nixpkgs-review pr 317170 at c24370a run on x86_64-linux 1

2 packages built successfully:
  • python311Packages.forbiddenfruit
  • python312Packages.forbiddenfruit

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 4, 2024
@fabaff
Copy link
Member

fabaff commented Jun 9, 2024

Result of nixpkgs-review pr 317170 run on x86_64-linux 1

4 packages built:
  • python311Packages.forbiddenfruit
  • python311Packages.forbiddenfruit.dist
  • python312Packages.forbiddenfruit
  • python312Packages.forbiddenfruit.dist

fabaff
fabaff approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 407d11d into NixOS:master Jun 9, 2024
@natsukium natsukium deleted the forbiddenfruit branch June 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@natsukium @fabaff