nodejs: move configure flags to a separate variable#317109
Closed
tie wants to merge 1 commit intoNixOS:masterfrom
Closed
nodejs: move configure flags to a separate variable#317109tie wants to merge 1 commit intoNixOS:masterfrom
tie wants to merge 1 commit intoNixOS:masterfrom
Conversation
Minor syntatic cleanup for the configureFlags list. Does not change derivations.
github-actions
bot
added
the
6.topic: nodejs
ofborg
bot
added
10.rebuild-darwin: 0
aduh95
approved these changes
Jun 4, 2024
tie
added
the
12.approved-by: package-maintainer
12 tasks
pbsds
reviewed
Jul 21, 2024
| in | ||
| [ | ||
| "--cross-compiling" | ||
| "--dest-cpu=${let platform = stdenv.hostPlatform; in |
Member
There was a problem hiding this comment.
Suggested change
| "--dest-cpu=${let platform = stdenv.hostPlatform; in | |
| "--dest-cpu=${ |
| else if platform.isx86_32 then "x86" | ||
| else if platform.isS390 && platform.is64bit then "s390x" | ||
| else if platform.isRiscV && platform.is64bit then "riscv64" | ||
| else throw "unsupported cpu ${stdenv.hostPlatform.uname.processor}"}" |
Member
There was a problem hiding this comment.
Suggested change
| else throw "unsupported cpu ${stdenv.hostPlatform.uname.processor}"}" | |
| else throw "unsupported cpu ${platform.uname.processor}"}" |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Minor syntatic cleanup for the configureFlags list. Does not change derivations.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.