Skip to content

[Backport staging-24.05] libiconv-darwin: fix crash and add support for static builds#316074

Merged
vcunat merged 2 commits intostaging-24.05from
backport-315180-to-staging-24.05
Jul 10, 2024
Merged

[Backport staging-24.05] libiconv-darwin: fix crash and add support for static builds#316074
vcunat merged 2 commits intostaging-24.05from
backport-315180-to-staging-24.05

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 31, 2024

Bot-based backport to staging-24.05, triggered by a label in #315180.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

reckenrode added 2 commits May 31, 2024 05:30
@reckenrode @github-actions
libiconv-darwin: add support for static builds
d184eb1 
(cherry picked from commit 067ad05)
@reckenrode @github-actions
libiconv-darwin: fix ISO-2022 with escape sequences crash
eb127c5 
This appears to be fixed in macOS 14.5, but the source release is not yet available.

(cherry picked from commit edfc324)
@github-actions github-actions bot mentioned this pull request May 31, 2024
Merged
13 tasks
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. labels May 31, 2024
@ofborg ofborg bot requested a review from reckenrode May 31, 2024 07:48
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 31, 2024
@roberth roberth mentioned this pull request Jun 25, 2024
Merged
@vcunat vcunat merged commit 53cabe0 into staging-24.05 Jul 10, 2024
@vcunat vcunat deleted the backport-315180-to-staging-24.05 branch July 10, 2024 15:23
@vcunat
Copy link
Member

vcunat commented Jul 10, 2024

Crossing my fingers. At least I see no complaints around the original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reckenrode reckenrode Awaiting requested review from reckenrode

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vcunat @reckenrode