Skip to content

nanopb: Fix self-inclusive src#315684

Merged
infinisil merged 1 commit intoNixOS:masterfrom
pyrox0:nanopb-self-inclusive-src
Jun 17, 2024
Merged

nanopb: Fix self-inclusive src#315684
infinisil merged 1 commit intoNixOS:masterfrom
pyrox0:nanopb-self-inclusive-src

Conversation

@pyrox0
Copy link
Member

@pyrox0 pyrox0 commented May 29, 2024

Description of changes

Fixes issue described in #301014

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 29, 2024
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in /nix/store/m7gli2lsr3niqzmr98wrx3cnik6bzwvi-test-message-with-annotations: default.nix
Only in /nix/store/h20vrxjjcjnig9s55rxbkpnd2458zys9-test-message-with-options: default.nix
Only in /nix/store/v7cz8jwf7qk7pxly0c1m92lx4pryihcy-test-simple-proto2: default.nix
Only in /nix/store/lk2apwq92iv9gys6iyc7d815nsc04cyl-test-simple-proto3: default.nix

I wrote a small script to test-what-the-difference-is.sh.txt

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 14, 2024
@pyrox0 pyrox0 force-pushed the nanopb-self-inclusive-src branch from 80b5c09 to 892f87e Compare June 15, 2024 16:42
@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants