libiconv-darwin: fix crash and add support for static builds#315180
Merged
vcunat merged 2 commits intoNixOS:stagingfrom May 31, 2024
Merged
libiconv-darwin: fix crash and add support for static builds#315180vcunat merged 2 commits intoNixOS:stagingfrom
vcunat merged 2 commits intoNixOS:stagingfrom
Conversation
13 tasks
ofborg
bot
added
6.topic: darwin
This appears to be fixed in macOS 14.5, but the source release is not yet available.
reckenrode
force-pushed
the
libiconv-darwin-fixes
branch
from
f22983b to
edfc324
Compare
Contributor
Author
|
Force push fixed a missing file for static builds. |
Contributor
|
Successfully created backport PR for |
Merged
1 task
Member
|
I'll trust that you know what you're doing here. |
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Two fixes for Darwin’s libiconv:
The crash seems similar to https://www.ambionics.io/blog/iconv-cve-2024-2961-p1. It appears to be fixed in macOS 14.5, but it’s not listed in https://support.apple.com/en-us/HT214106.
The patch can be dropped once the corresponding source release is available.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.